Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build CLI for Ubuntu 20.04, 22.04, and AppImage #459

Merged
merged 2 commits into from
Aug 15, 2023
Merged

Build CLI for Ubuntu 20.04, 22.04, and AppImage #459

merged 2 commits into from
Aug 15, 2023

Conversation

thomasten
Copy link
Member

Proposed changes

  • Upgrade Dockerfile.coordinator to Ubuntu 22.04
    • Rename CLI produced by this Dockerfile to marblerun-ubuntu-22.04
  • Add Dockerfile.cli
    • Builds the CLI for Ubuntu 20.04 and an AppImage of it
    • AppImages usually don't include libc and thus recommend to build on the lowest supported OS version, which is 20.04 because of OE
    • The AppImage includes the default QPL

@netlify
Copy link

netlify bot commented Aug 14, 2023 •
edited
Loading

✅ Deploy Preview for marblerun-docs canceled.

Name Link
🔨 Latest commit d0a93fc
🔍 Latest deploy log https://app.netlify.com/sites/marblerun-docs/deploys/64db82fa04c9110008941d10

daniel-weisse
daniel-weisse reviewed Aug 15, 2023
View reviewed changes
Copy link
Member

@daniel-weisse daniel-weisse left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the AppImage on Ubuntu 20.04 and Fedora 37, both worked fine 👍
Can you add build instructions to BUILD.md, and/or our wiki?

dockerfiles/Dockerfile.coordinator Show resolved Hide resolved
dockerfiles/Dockerfile.cli Show resolved Hide resolved
@thomasten thomasten merged commit ba56d48 into master Aug 15, 2023
4 of 5 checks passed
@thomasten thomasten deleted the feat/appimage branch August 15, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-weisse daniel-weisse daniel-weisse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thomasten @daniel-weisse