Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only work on store transactions #388

Merged
merged 7 commits into from
May 2, 2023
Merged

Only work on store transactions #388

merged 7 commits into from
May 2, 2023

Conversation

daniel-weisse
Copy link
Member

@daniel-weisse daniel-weisse commented Apr 17, 2023 •
edited
Loading

Proposed changes

  • Stop embedding store Wrappers in the Coordinator parts
  • Only read data from transactions to make sure all information obtained during one call comes from the same state
  • Marble Activation: Only commit state if MaxActivations is something we care about, dismiss state changes otherwise.
    • This reduces the amount of state updates we need to perform once MarbleRun is properly set up and running.

@netlify
Copy link

netlify bot commented Apr 17, 2023 •
edited
Loading

✅ Deploy Preview for marblerun-docs ready!

Name Link
🔨 Latest commit 47877f3
🔍 Latest deploy log https://app.netlify.com/sites/marblerun-docs/deploys/6450be515ad6e700080204b8
😎 Deploy Preview https://deploy-preview-388--marblerun-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@daniel-weisse daniel-weisse force-pushed the feat/coordinator/read-tx branch 2 times, most recently from 4631743 to 8d33dcb Compare April 25, 2023 09:13
@daniel-weisse daniel-weisse marked this pull request as ready for review April 25, 2023 09:27
@daniel-weisse daniel-weisse force-pushed the feat/coordinator/read-tx branch 3 times, most recently from 451832a to 34bb7af Compare April 25, 2023 12:46
thomasten
thomasten approved these changes Apr 28, 2023
View reviewed changes
Copy link
Member

@thomasten thomasten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

coordinator/store/wrapper/wrapper.go Outdated Show resolved Hide resolved
coordinator/clientapi/clientapi_test.go Outdated Show resolved Hide resolved
coordinator/store/wrapper/testutil/testutil.go Outdated Show resolved Hide resolved
@daniel-weisse daniel-weisse merged commit 2cac366 into master May 2, 2023
@daniel-weisse daniel-weisse deleted the feat/coordinator/read-tx branch May 2, 2023 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasten thomasten thomasten approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daniel-weisse @thomasten