Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor CLI code #380

Merged
merged 12 commits into from
Mar 22, 2023
Merged

Refactor CLI code #380

merged 12 commits into from
Mar 22, 2023

Conversation

daniel-weisse
Copy link
Member

@daniel-weisse daniel-weisse commented Mar 6, 2023

Proposed changes

  • Remove deprecated gramine-prepare command
  • Move CLI code to cli/internal/cmd/
  • Move Coordinator REST interaction to separate package
  • Move helm interaction to separate package
  • Move Kubernetes client setup to separate package
    • Could be further refactored by only returning a limited interface instead of a fully fledged Kubernetes client, but I think its fine for now
  • Add package for file interaction

Signed-off-by: Daniel Weiße <[email protected]>
Signed-off-by: Daniel Weiße <[email protected]>
Signed-off-by: Daniel Weiße <[email protected]>
Signed-off-by: Daniel Weiße <[email protected]>
@netlify
Copy link

netlify bot commented Mar 6, 2023

Deploy Preview for marblerun-docs canceled.

Name Link
🔨 Latest commit cd679c4
🔍 Latest deploy log https://app.netlify.com/sites/marblerun-docs/deploys/641afbe844ddfe0008d11fa7

@daniel-weisse daniel-weisse marked this pull request as ready for review March 7, 2023 08:48
Copy link
Member

@m1ghtym0 m1ghtym0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Massive PR:O
Conceptually, the changes make sense to me.
I went over the changes but didn't do a throughout review of the code.
As most changes are refactoring I believe that the unit tests should ensure things are consistent.

Copy link
Member

@thomasten thomasten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got one question in certificate_test.go. Otherwise only nits. Choose yourself which ones you want to apply.

cli/cmd/root.go Outdated Show resolved Hide resolved
cli/internal/rest/rest.go Outdated Show resolved Hide resolved
cli/internal/rest/rest.go Outdated Show resolved Hide resolved
cli/internal/rest/rest.go Outdated Show resolved Hide resolved
cli/internal/rest/rest.go Outdated Show resolved Hide resolved
cli/internal/cmd/manifest_test.go Outdated Show resolved Hide resolved
cli/internal/cmd/manifest_test.go Outdated Show resolved Hide resolved
cli/internal/cmd/manifest_test.go Outdated Show resolved Hide resolved
cli/internal/cmd/secret_test.go Outdated Show resolved Hide resolved
cli/internal/cmd/secret_test.go Outdated Show resolved Hide resolved
cli/internal/rest/rest.go Outdated Show resolved Hide resolved
@daniel-weisse daniel-weisse merged commit 99165e4 into master Mar 22, 2023
@daniel-weisse daniel-weisse deleted the ref/cli branch March 22, 2023 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants