Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't panic #360

Merged
merged 2 commits into from
Jan 27, 2023
Merged

Don't panic #360

merged 2 commits into from
Jan 27, 2023

Conversation

daniel-weisse
Copy link
Member

Proposed changes

  • As the PR title already says: don't panic in the Marble PreMain or Coordinator main function
    • Instead, print an error message to stderr and exit code 1
  • Remove stack trace on error in Coordinator

@netlify
Copy link

netlify bot commented Jan 27, 2023 •
edited
Loading

✅ Deploy Preview for marblerun-docs canceled.

Name Link
🔨 Latest commit b877184
🔍 Latest deploy log https://app.netlify.com/sites/marblerun-docs/deploys/63d3ea0aa4b5fa000c8e832f

Nirusu
Nirusu approved these changes Jan 27, 2023
View reviewed changes
Copy link
Contributor

@Nirusu Nirusu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love

+ colored.
@@ output  @@
! Thanks!

@daniel-weisse daniel-weisse merged commit 1a1c46e into master Jan 27, 2023
@daniel-weisse daniel-weisse deleted the feat/dont-panic branch January 27, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nirusu Nirusu Nirusu approved these changes

@m1ghtym0 m1ghtym0 m1ghtym0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daniel-weisse @m1ghtym0 @Nirusu