Update samples and PreMain for Gramine v1.3 compatibility #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for marblerun-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
daniel-weisse
force-pushed
the
fix/samples/gramine-v1.3
branch
from
67104d2
to
09b973d
Compare
Nirusu
reviewed
Jan 10, 2023
Nirusu
reviewed
Jan 10, 2023
daniel-weisse
force-pushed
the
fix/samples/gramine-v1.3
branch
from
bd84d34
to
5c59dcc
Compare
Nirusu
approved these changes
Jan 11, 2023
Signed-off-by: Daniel Weiße <[email protected]>
Signed-off-by: Daniel Weiße <[email protected]>
Signed-off-by: Daniel Weiße <[email protected]>
Signed-off-by: Daniel Weiße <[email protected]>
Signed-off-by: Daniel Weiße <[email protected]>
Signed-off-by: Daniel Weiße <[email protected]>
Signed-off-by: Daniel Weiße <[email protected]>
Signed-off-by: Daniel Weiße <[email protected]>
daniel-weisse
force-pushed
the
fix/samples/gramine-v1.3
branch
from
5c59dcc
to
865b9dd
Compare
Signed-off-by: Daniel Weiße <[email protected]>
m1ghtym0
approved these changes
Jan 13, 2023
Co-authored-by: Moritz Eckert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Went over our samples and tried to make them functional for v1.3.
Ran into a couple issues with the nginx sample, but they are fixed now.
I have also updated the Gramine PreMain to now be compatible with the new encrypted key format, which was first introduced in Gramine v1.2, and squashed a "bug" where the protected files key was written twice.
Additional info
I marked the gramine-prepare command as deprecated for now, since usage seems to be low/non existent, and keeping it up to date or compatible with the latest Gramine manifest syntax seems to be more of a hassle than its worth.