Fix an error that occurs when get a coordinator certificate #308

llnut · 2022-07-21T11:07:21Z

use "era-config.json" instead of configFilename variable when the latter is empty.

…latter is empty

CLAassistant · 2022-07-21T11:07:26Z

All committers have signed the CLA.

m1ghtym0 · 2022-07-21T11:52:11Z

Fix LGTM, not sure if we want to move that string into a constant?

llnut · 2022-07-21T12:32:28Z

Fix LGTM, not sure if we want to move that string into a constant?

I updated the code, can you please review it?

m1ghtym0 · 2022-07-21T12:37:36Z

@jcsora Can you sign the CLA, please?

llnut · 2022-07-21T13:04:21Z

@jcsora Can you sign the CLA, please?

Yes i just finished signing.

cli/cmd/util.go

fix era config filename Co-authored-by: Daniel Weiße <[email protected]>

fix: use era-config.json instead of configFilename variable when the …

ca1e875

…latter is empty

m1ghtym0 requested a review from daniel-weisse July 21, 2022 11:51

m1ghtym0 added the bug Something isn't working label Jul 21, 2022

m1ghtym0 assigned daniel-weisse Jul 21, 2022

Use constant to store era default config file path

91147b5

daniel-weisse reviewed Jul 21, 2022

View reviewed changes

cli/cmd/util.go Outdated Show resolved Hide resolved

llnut and others added 2 commits July 22, 2022 10:24

Update cli/cmd/util.go

656e677

fix era config filename Co-authored-by: Daniel Weiße <[email protected]>

fix era config filename

4830551

llnut closed this Jul 22, 2022

llnut reopened this Jul 22, 2022

daniel-weisse approved these changes Jul 22, 2022

View reviewed changes

daniel-weisse merged commit a48368c into edgelesssys:master Jul 22, 2022

Provide feedback