Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coordinator API - endpoint for manifest signature #291

Merged
merged 5 commits into from
Apr 1, 2022

Conversation

fnerdman
Copy link
Contributor

Proposed changes

  • enhance the Coordinator API manifest endpoint to return the manifests ECDSA signature - signed by intermediate key

Related issue

Open Questions

  • The ECDSA signature contains a random element, which means that with the current implementation the signature will change upon each request. An attacker who would like to guess the ECDSA key might find this useful. It could be sensible to create the signature only once and store it in the storeWrapper. @m1ghtym0 any preferences?

@fnerdman
Copy link
Contributor Author

rfc6979 would also be an option to make the signature output deterministic, however, I can not find an implementation in go which is trustworthy.

@daniel-weisse
Copy link
Member

Writing the signature to the store seems like the most sensible idea for now.
I would add the generation and writing to store in SetManifest().

@fnerdman
Copy link
Contributor Author

@daniel-weisse the manifest signature is now deterministic by setting it once and moving it to the store.
I've just now figured out how manifest updates are handled. As the original manifest is never touched - only update logs exist - it doesn't really make sense to sign the manifest with the intermediate key.
I would add another patch that uses the root key for signing the manifest. This would mean manifest updates still can not be verified by key signatures, but I would propose to postpone this issue to another PR.

@fnerdman fnerdman marked this pull request as ready for review March 30, 2022 12:49
@fnerdman
Copy link
Contributor Author

@daniel-weisse Please review

Copy link
Member

@daniel-weisse daniel-weisse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.
Looks good to me, just three small things:

coordinator/server/client_api.go Outdated Show resolved Hide resolved
coordinator/server/client_api.go Outdated Show resolved Hide resolved
coordinator/core/clientapi_test.go Outdated Show resolved Hide resolved
coordinator/server/client_api.go Show resolved Hide resolved
coordinator/server/client_api.go Outdated Show resolved Hide resolved
@daniel-weisse daniel-weisse merged commit 4337f72 into edgelesssys:master Apr 1, 2022
edgelessci pushed a commit to edgelesssys/docs.edgeless.systems that referenced this pull request Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants