-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Coordinator API - endpoint for manifest signature #291
Coordinator API - endpoint for manifest signature #291
Conversation
rfc6979 would also be an option to make the signature output deterministic, however, I can not find an implementation in go which is trustworthy. |
Writing the signature to the store seems like the most sensible idea for now. |
@daniel-weisse the manifest signature is now deterministic by setting it once and moving it to the store. |
@daniel-weisse Please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR.
Looks good to me, just three small things:
Proposed changes
manifest
endpoint to return the manifests ECDSA signature - signed by intermediate keyRelated issue
Open Questions