Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manifest: add WorkloadSecretID field #785

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

3u13r
Copy link
Member

@3u13r 3u13r commented Aug 2, 2024

This field will be used as part of the workload secret feature (RFC 007) to generate secrets.

Since we now need to assign multiple different values to a policy hash, we also introduce the "SANs" field, which contains the information previously contained directly as value.

@3u13r 3u13r added the breaking change A user-affecting breaking change label Aug 2, 2024
@3u13r 3u13r marked this pull request as ready for review August 2, 2024 17:29
@3u13r 3u13r requested a review from katexochen as a code owner August 2, 2024 17:29
@3u13r 3u13r force-pushed the feat/manifest/add-workload-secret-id-field branch from d0f0115 to c6faca6 Compare August 2, 2024 17:31
internal/manifest/manifest.go Outdated Show resolved Hide resolved
@katexochen katexochen requested a review from burgerdev August 5, 2024 06:04
This field will be used as part of the workload secret feature (RFC 007) to generate secrets.
@3u13r 3u13r force-pushed the feat/manifest/add-workload-secret-id-field branch from c6faca6 to f461a54 Compare August 5, 2024 06:59
@3u13r 3u13r merged commit d8387e6 into main Aug 5, 2024
9 checks passed
@3u13r 3u13r deleted the feat/manifest/add-workload-secret-id-field branch August 5, 2024 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change A user-affecting breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants