meshapi: follow best practice for metric names #722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Counters should have a _total suffix. Signed-off-by: Paul Meyer <[email protected]>
katexochen
force-pushed
the
p/prom-best-prac
branch
from
8529e16 to
73c0e8e
Compare
Freax13
approved these changes
Jul 12, 2024
| Name: "attestation_failures", | ||
| Name: "attestation_failures_total", |
There was a problem hiding this comment.
Have you considered creating a constant containing this value? We could reuse the constant in the tests.
There was a problem hiding this comment.
Might be a good idea if we want to use this in more places in the future, or must reference more label names elsewhere. But I think in general building up tests on metrics as insight isn't that good of a design.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Counters should have a _total suffix, so we are renaming
contrast_meshapi_attestation_failures->contrast_meshapi_attestation_failures_total.This will also be enforced by #721 in the future.