Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: derive runtime class name from launch digest #618

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

davidweisse
Copy link
Contributor

Instead of injecting the runtime handler into the CLI, we can directly derive it from the trusted measurement.

@davidweisse davidweisse requested a review from msanft June 21, 2024 14:58
@davidweisse davidweisse added the no changelog PRs not listed in the release notes label Jun 21, 2024
Base automatically changed from feat/better-version-command to main June 24, 2024 12:55
@davidweisse davidweisse force-pushed the dav/runtimeclass-from-trusted-measurement branch from 9c74b0d to ae87cc7 Compare June 24, 2024 13:01
@davidweisse davidweisse marked this pull request as ready for review June 24, 2024 13:01
@davidweisse davidweisse requested a review from katexochen as a code owner June 24, 2024 13:01
cli/cmd/common.go Outdated Show resolved Hide resolved
@davidweisse davidweisse force-pushed the dav/runtimeclass-from-trusted-measurement branch 3 times, most recently from a859c88 to 2edbd3d Compare June 25, 2024 15:36
@davidweisse davidweisse requested a review from msanft June 26, 2024 07:18
@davidweisse davidweisse force-pushed the dav/runtimeclass-from-trusted-measurement branch from 2edbd3d to 8e0e146 Compare June 26, 2024 07:47
@davidweisse davidweisse merged commit 5962210 into main Jun 26, 2024
8 checks passed
@davidweisse davidweisse deleted the dav/runtimeclass-from-trusted-measurement branch June 26, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog PRs not listed in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants