Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manifest: check for empty trusted measurement #616

Conversation

davidweisse
Copy link
Contributor

Previously, if the TrustedMeasurement field in the manifest was left empty, no error would be produced and the attestation would simply skip the measurement check. The correct way to check for the measurement would be to check if it is empty and not nil. In that case, the value is overridden with 48 zero bytes and the attestation should fail.

@davidweisse davidweisse added the bug fix Fixing a user facing bug label Jun 21, 2024
@davidweisse davidweisse requested a review from burgerdev June 21, 2024 14:31
@davidweisse davidweisse requested a review from katexochen as a code owner June 21, 2024 14:31
Copy link
Contributor

@burgerdev burgerdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the trusted measurement is empty but non-nil, does this mean that the user explicitly configured it? Shouldn't we respect that?

@katexochen
Copy link
Member

If the trusted measurement is empty but non-nil, does this mean that the user explicitly configured it? Shouldn't we respect that?

Why? To allow the user to disable fundamental security checks?

@burgerdev
Copy link
Contributor

I'd argue that a user who actively resets the measurement in the generated manifest should have the right to do so, but I see your point that this is a footgun with no concrete use case.

@davidweisse
Copy link
Contributor Author

If the user should not be able to disable the trusted measurement check, then #630 already covers this and we can close this PR.

Copy link
Contributor

@burgerdev burgerdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do this - if a use case should come up, allowing it should be easy enough.

@davidweisse davidweisse deleted the dav/manifest-trusted-measurement-check branch June 25, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix Fixing a user facing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants