Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coordinator: enable recovery #613

Merged
merged 2 commits into from
Jun 24, 2024
Merged

coordinator: enable recovery #613

merged 2 commits into from
Jun 24, 2024

Conversation

burgerdev
Copy link
Contributor

@burgerdev burgerdev commented Jun 20, 2024

This PR consists of two commits:

  1. Consolidate getManifestAndLatestCA with GetManifests. This is a follow-up to coordinator: uniform gRPC metric prefix  #583, essentially moving the function body of the former into the latter while simplifying the latter with the internals now available to it.
  2. Add a test for the recovery scenario and add detection for the "recovery needed" condition.

It should be the last change to implement RFC004 on the Coordinator side.

@burgerdev burgerdev force-pushed the burgerdev/recovery branch from dfc32ee to 6d03483 Compare June 20, 2024 15:29
@burgerdev burgerdev added the no changelog PRs not listed in the release notes label Jun 20, 2024
@burgerdev burgerdev marked this pull request as ready for review June 20, 2024 15:41
@burgerdev burgerdev requested a review from katexochen as a code owner June 20, 2024 15:41
@katexochen katexochen self-assigned this Jun 21, 2024
@burgerdev burgerdev merged commit afdc62e into main Jun 24, 2024
8 of 9 checks passed
@burgerdev burgerdev deleted the burgerdev/recovery branch June 24, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog PRs not listed in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants