generate: add flag for aks reference values #612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burgerdev
reviewed
Jun 21, 2024
davidweisse
force-pushed
the
dav/manifest-aks-ref-values-flag
branch
from
223ade8 to
f9bd971
Compare
katexochen
reviewed
Jun 21, 2024
The manifest will be generated with invalid null values when the flag is not specified which must be filled out by the user.
davidweisse
force-pushed
the
dav/manifest-aks-ref-values-flag
branch
from
f9bd971 to
41a4804
Compare
burgerdev
approved these changes
Jun 25, 2024
katexochen
added
breaking change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for fields in the manifest to have the value
"null", in which case the attestation will fail when trying to parse the validation options from the manifest. This is helpful when generating the manifest for the first time withcontrast generatewhere the SNP reference values are now left empty ("null") by default. The default reference values used for AKS can then optionally be generated with the--reference-values aksflag.