genpolicy: add flag for cache path #593
Conversation
3u13r
force-pushed
the
feat/genpolicy/cache-path
branch
2 times, most recently
from
b8b4bfd to
a7cd4d0
Compare
3u13r
changed the title
cli/cmd/generate.go
Outdated
| @@ -391,7 +391,7 @@ func addWorkloadOwnerKeyToManifest(manifst *manifest.Manifest, keyPath string) e | |||
| func generatePolicyForFile(ctx context.Context, genpolicyPath, regoPath, policyPath, yamlPath string, logger *slog.Logger) ([32]byte, error) { | |||
| args := []string{ | |||
| "--raw-out", | |||
| "--use-cached-files", | |||
| "--layers-cache-file-path=./layers-cache.json", | |||
There was a problem hiding this comment.
this should be made configurable through a flag, defaulting to the file being at a default location within the configured workspaceDir.
3u13r
force-pushed
the
feat/genpolicy/cache-path
branch
2 times, most recently
from
bae60df to
228a55c
Compare
|
Done. Do we already have a use for this e.g. somewhere in the CI? We currently don't list explicit CLI features in the docs, so there's also nothing to add here, I assume. |
There was a problem hiding this comment.
Do we already have a use for this e.g. somewhere in the CI?
As you correctly merge cache-path with workspace-dir, this change will already have effect on the dev workflow where the workspace is set. We will now generate on every just generate invocation, where we would previously often use the cache. A shift towards more correctness at the cost of performance, let's see how it goes.
3u13r
force-pushed
the
feat/genpolicy/cache-path
branch
from
228a55c to
0e7f658
Compare
Upstream PR: kata-containers/kata-containers#9864
For now, this should have no change to the user.
The question is, how we now want to use this option. Also have a similar flag in our CLI or just have a general home/.config path.
TODO:
git format-patchto create initial patch file