Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

treewide: rename environment variables from EDG_* to CONTRAST_* #572

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

miampf
Copy link
Contributor

@miampf miampf commented Jun 13, 2024

Rename the following environment variables:

  • EDG_INGRESS_PROXY_CONFIGCONTRAST_INGRESS_PROXY_CONFIG
  • EDG_EGRESS_PROXY_CONFIGCONTRAST_EGRESS_PROXY_CONFIG
  • EDG_ADMIN_PORTCONTRAST_ADMIN_PORT
  • EDG_INBOUNDCONTRAST_INBOUND
  • EDG_IN_REDIRECTCONTRAST_IN_REDIRECT

@miampf miampf added changelog PRs that should be part of the release notes breaking change A user-affecting breaking change labels Jun 13, 2024
@katexochen katexochen removed the changelog PRs that should be part of the release notes label Jun 13, 2024
@katexochen katexochen changed the title breaking: Rename some environment variables from EDG_* to CONTRAST_* treewide: rename environment variables from EDG_* to CONTRAST_* Jun 13, 2024
Copy link

github-actions bot commented Jun 13, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-06-14 13:12 UTC

@miampf miampf force-pushed the chore/use-contrast-env-prefix branch 2 times, most recently from a142df0 to 943df9c Compare June 14, 2024 11:54
@miampf miampf marked this pull request as ready for review June 14, 2024 12:04
@miampf miampf requested a review from katexochen as a code owner June 14, 2024 12:04
@miampf miampf requested review from 3u13r and davidweisse and removed request for katexochen June 14, 2024 12:04
Copy link
Member

@3u13r 3u13r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@miampf miampf force-pushed the chore/use-contrast-env-prefix branch from 943df9c to 70fe49d Compare June 14, 2024 13:05
@miampf miampf merged commit d444ba8 into main Jun 14, 2024
9 checks passed
@miampf miampf deleted the chore/use-contrast-env-prefix branch June 14, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change A user-affecting breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants