release: test in the default namespace #562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidweisse
reviewed
Jun 12, 2024
burgerdev
force-pushed
the
burgerdev/release-test-default
branch
from
bb0d2cd to
d56bf63
Compare
burgerdev
force-pushed
the
burgerdev/release-test-default
branch
from
d56bf63 to
3d1edb4
Compare
davidweisse
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings us closer to the documented instructions (we had a broken release before because of this discrepancy).
Drive-by: use the appropriate way to determine whether an unstructured object is namespaced or not. This allows applying/deleting resources with no (or empty) namespace using kubeclient.