cli: separate nix rule for cli release build #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katexochen
reviewed
Feb 8, 2024
burgerdev
force-pushed
the
burgerdev/generate-policy-hash
branch
2 times, most recently
from
f5f2142 to
4549f47
Compare
burgerdev
force-pushed
the
burgerdev/generate-policy-hash
branch
from
4549f47 to
43c006d
Compare
katexochen
reviewed
Feb 8, 2024
burgerdev
force-pushed
the
burgerdev/generate-policy-hash
branch
2 times, most recently
from
e7dcac0 to
5a96e7c
Compare
katexochen
reviewed
Feb 9, 2024
katexochen
reviewed
Feb 9, 2024
burgerdev
force-pushed
the
burgerdev/generate-policy-hash
branch
2 times, most recently
from
492e11d to
1f91296
Compare
katexochen
approved these changes
Feb 9, 2024
We would like to include a standard coordinator policy hash into cli releases, so that the coordinator can be deployed separately and is still verified by the cli. We cannot embed a default coordinator policy into the existing build rule: * To generate a policy hash, we need to build the coordinator, publish it as an OCI image and run genpolicy on it. * To embed the hash in the binary, it needs to go into the build inputs. * If it's in the build inputs, the output store location changes. * If the output store location changes, the OCI layer (and thus the required policy) changes. On the other hand, we would like to keep the multi-binary build rule for development, so we introduce a new build rule exclusively for cli releases, and only that rule consumes the coordinator policy hash as input. Co-authored-by: Paul Meyer <[email protected]>
burgerdev
force-pushed
the
burgerdev/generate-policy-hash
branch
from
1f91296 to
dc0c76c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We would like to include a standard coordinator policy hash into cli
releases, so that the coordinator can be deployed separately and is
still verified by the cli.
We cannot embed a default coordinator policy into the existing build
rule:
it as an OCI image and run genpolicy on it.
required policy) changes.
On the other hand, we would like to keep the multi-binary build rule for
development, so we introduce a new build rule exclusively for cli
releases, and only that rule consumes the coordinator policy hash as
input.