Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kuberesource: use only PVC wrapper #1177

Merged
merged 1 commit into from
Jan 23, 2025
Merged

kuberesource: use only PVC wrapper #1177

merged 1 commit into from
Jan 23, 2025

Conversation

burgerdev
Copy link
Contributor

Using the wrapper removes the empty namespace from the volume claim templates in our stateful sets. This is only an aesthetic fix, the explicit empty namespace also does the right thing.

@burgerdev burgerdev added the no changelog PRs not listed in the release notes label Jan 23, 2025
@burgerdev burgerdev requested a review from katexochen January 23, 2025 09:49
katexochen
katexochen approved these changes Jan 23, 2025
View reviewed changes
Copy link
Member

@katexochen katexochen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@burgerdev burgerdev merged commit 83d3208 into main Jan 23, 2025
12 checks passed
@burgerdev burgerdev deleted the burgerdev/namespaces branch January 23, 2025 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katexochen katexochen katexochen approved these changes

Assignees
No one assigned
Labels
no changelog PRs not listed in the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@burgerdev @katexochen