Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

generate: add flag to skip service mesh injection #1122

Merged
merged 1 commit into from
Jan 9, 2025
Merged

generate: add flag to skip service mesh injection #1122

merged 1 commit into from
Jan 9, 2025

Conversation

katexochen
Copy link
Member

This allows to keep existing service mesh parts including modifications.

@katexochen katexochen added the feature Shiny new feature for our users label Jan 7, 2025
@katexochen katexochen requested a review from davidweisse January 7, 2025 09:26
davidweisse
davidweisse reviewed Jan 7, 2025
View reviewed changes
Copy link
Contributor

@davidweisse davidweisse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we just remove the annotation in the YAML which is responsible for injecting the service mesh? Any existing service mesh container should remain unchanged on generate.

@katexochen
Copy link
Member Author

Can't we just remove the annotation in the YAML which is responsible for injecting the service mesh? Any existing service mesh container should remain unchanged on generate.

I think we can still add this flag for consistency and faster toggle. wdyt @burgerdev?

burgerdev
burgerdev approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@burgerdev burgerdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a common use case, but on the other hand I don't see a downside.

@katexochen katexochen merged commit d8ebea9 into main Jan 9, 2025
12 checks passed
@katexochen katexochen deleted the p/skip-service-mesh branch January 9, 2025 11:43
@katexochen katexochen added changelog PRs that should be part of the release notes and removed feature Shiny new feature for our users labels Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidweisse davidweisse davidweisse left review comments

@burgerdev burgerdev burgerdev approved these changes

Assignees
No one assigned
Labels
changelog PRs that should be part of the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@katexochen @burgerdev @davidweisse