Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e2e: use real reference values on bare-metal runners #1115

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

e2e: use real reference values on bare-metal runners #1115

wants to merge 1 commit into from

Conversation

jmxnzo
Copy link
Contributor

@jmxnzo jmxnzo commented Jan 2, 2025 •
edited
Loading

Until now we are using the generated reference values in our e2e tests on bare metal, which contain placeholder null values. This PR ensures, that the reference values of our e2e test correctly reflect the bare-metal runners (tdx & snp).

  • A ConfigMap, persistently storing the missing reference values of our bare-metal runners was added to our e2e cluster. Thus reachable by any workflow ran on the e2e cluster.
  • Reworked e2e testing logic of patchReferenceValues() as stated in #1104 by moving the invalidation of reference values into an own function

@jmxnzo jmxnzo added the no changelog PRs not listed in the release notes label Jan 2, 2025
@jmxnzo jmxnzo mentioned this pull request Jan 2, 2025
Merged
@jmxnzo jmxnzo force-pushed the e2e/baremetal-runner-tcb branch from 1cfb8a9 to 52ae4ee Compare January 2, 2025 14:10
@jmxnzo jmxnzo marked this pull request as ready for review January 2, 2025 15:37
@jmxnzo jmxnzo requested a review from burgerdev as a code owner January 2, 2025 15:37
burgerdev
burgerdev reviewed Jan 2, 2025
View reviewed changes
.github/workflows/e2e.yml Outdated Show resolved Hide resolved
e2e/internal/contrasttest/contrasttest.go Outdated Show resolved Hide resolved
e2e/internal/contrasttest/testdata/snp-minimum-tcb.json Outdated Show resolved Hide resolved
e2e/internal/contrasttest/contrasttest.go Outdated Show resolved Hide resolved
@jmxnzo jmxnzo changed the title e2e: use real minimumTCB values on bare-metal runners e2e: use real reference values on bare-metal runners Jan 3, 2025
@jmxnzo jmxnzo force-pushed the e2e/baremetal-runner-tcb branch from 6e05d8c to bf6c701 Compare January 3, 2025 16:29
@jmxnzo jmxnzo requested a review from burgerdev January 3, 2025 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@burgerdev burgerdev Awaiting requested review from burgerdev burgerdev is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
no changelog PRs not listed in the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmxnzo @burgerdev