Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] SONiC Extension Packages Migration Error During New SONiC Image Install #8

Merged

Conversation

PeterTSW-EC
Copy link

What I did

  • SONiC updates the format of the CLI section in the manifest.json on 17/5/2023. (Link)
  • The implementation was merged to master, 202311, or later branches. (Link)
  • However, the PR #2753 Comment reported that an error occurred when the CLI migration.
  • The root cause is occurred while a CLI field (show/config/clear) is empty ('').
  • This PR corrects the manifest.json parser that leaves the empty list ([]) instead of a list with an empty string (['']) when the CLI field is empty ('').

How I did it

  • Update the manifest.py, and add a condition that returns an empty list ([]) when the CLI field is an empty string (''); Otherwise, return a list with a single string path (['/xxx/xxx']).

How to verify it

Execute the command "sudo sonic-package-manager install -y --from-tarball ./docker-test.gz", or install a new version of the SONiC image. (It executes the "sonic-package-manager migrate" during the installation. )

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

… Install

* In 17/05/2023, SONiC updates the format of CLI section in the manifest.json.
* The implementation was updated in 202311 or later branches.
* However, the PR #2753 reported there is a error occur when the CLI migration.
* The root cause is occurred while a CLI field (show/config/clear) is empty ('').
* This PR modifies the parser of the cli_plugins field in the manifest.py.
@PeterTSW-EC
Copy link
Author

@CharlieChenEC @vincentchiang-ec @PJHsieh
Please help to review this PR.
Thanks

@CharlieChenEC CharlieChenEC merged commit 3e46c54 into edge-core:202311.X Jul 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants