xcvrd exception when change port speed for RJ45 ports #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Root Cause:
exception log:
ERR pmon#xcvrd: File "/usr/local/lib/python3.9/dist-packages/sonic_platform_base/sonic_xcvr/sfp_optoe_base.py", line 244, in read_eeprom
ERR pmon#xcvrd: with open(self.get_eeprom_path(), mode='rb', buffering=0) as f:
ERR pmon#xcvrd: File "/usr/local/lib/python3.9/dist-packages/sonic_platform/sfp.py", line 80, in get_eeprom_path
ERR pmon#xcvrd: return self.port_to_eeprom_mapping[self.port_num]
ERR pmon#xcvrd: KeyError: 1
There is no eeprom for RJ45.
Solution:
There is no need for a pre-emphasis setting if a transceiver is not inserted.
It always returns false from "get_presence" for RJ45.
Added a check to see if a transceiver is presented before applying the media setting.
CharlieChenEC
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Root Cause:
exception log:
There is no eeprom for RJ45.
Solution:
There is no need for a pre-emphasis setting if a transceiver is not inserted.
It always returns false from "get_presence" for RJ45.
Added a check to see if a transceiver is presented before applying the media setting.
Description
Motivation and Context
How Has This Been Tested?
Additional Information (Optional)