Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sync PR]: Sync #457 to fix AS9817-64O pytest port toggle failed. #5

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

tigerfu000
Copy link

Why I did it

  • To fix AS9817-64O pytest port toggle failed.

How I did it

  • Sync community PR: Aligning SONiC code with sff8024 spec (#457).

How to verify it

  • Re-run pytest port toggle can pass.

Description

Motivation and Context

How Has This Been Tested?

Additional Information (Optional)

* Updated sff8024.py to align with sff8024 spec (fixes and additions)

* A fix for the method of retrieving the application advertisement list from the EEPROM of CMIS modules

* Added a unit test to validate the result of get_application_advertisement() for applications with missing data
@tigerfu000 tigerfu000 changed the title [Sync PR#457]: Sync PR to fix AS9817-64O pytest port toggle failed. [Sync PR]: Sync #457 to fix AS9817-64O pytest port toggle failed. Aug 13, 2024
@kevin28-9219 kevin28-9219 merged commit 5f091d8 into edge-core:202311.0 Aug 13, 2024
1 check passed
@tigerfu000 tigerfu000 deleted the 202311.0_sync_pr#457 branch August 30, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants