Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First build the image usingFirstdocker-compose build
.rm -rf node_modules
. (Thanks @pgoetze for pointing that out) Then build the image usingdocker-compose build
. This will:node:argon
npm install
when building the image and keeps installed modules in/tmp/node_modules
Then create and start a new container based on the previously built image using
docker-compose up
. This will:/app
inside the containernode_modules
pointing to/tmp/node_modules
if not already presentnode_modules/pre-commit/hook
inside the containernpm run dev
8000
(babel) on the Docker machine's port80
8080
(webpack) on the Docker machine's port8080
@mattberridge, @pgoetze, @artibella could you please give it a try and also check, whether the pre-commit hook is working properly?