Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFR] Made the tab system rely on hash #11

Merged
merged 1 commit into from
Dec 22, 2015
Merged

[RFR] Made the tab system rely on hash #11

merged 1 commit into from
Dec 22, 2015

Conversation

KittyGiraudel
Copy link
Contributor

  • The tab system now relies on hash and links rather than JavaScript click handler
  • An initial hash will open the accurate tab
  • A hash change will open the accurate tab

@KittyGiraudel
Copy link
Contributor Author

Ping @eschaefer for review.

@KittyGiraudel KittyGiraudel mentioned this pull request Dec 22, 2015
Open
@KittyGiraudel KittyGiraudel force-pushed the feature/hash-based-navigation branch 5 times, most recently from d03c866 to b4b8644 Compare December 22, 2015 16:23
@KittyGiraudel KittyGiraudel force-pushed the feature/hash-based-navigation branch from b4b8644 to 11db896 Compare December 22, 2015 16:24
@KittyGiraudel
Copy link
Contributor Author

Re-ping @eschaefer for review.

@eschaefer
Copy link
Contributor

👍

eschaefer added a commit that referenced this pull request Dec 22, 2015
@eschaefer
Merge pull request #11 from edenspiekermann/feature/hash-based-naviga…
b1fed66 
…tion

[RFR] Made the tab system rely on hash
@eschaefer eschaefer merged commit b1fed66 into master Dec 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KittyGiraudel @eschaefer