Removed the need for JSON parsing to improve performance

edenspiekermann · Mar 11, 2016 · d835cc9 · d835cc9
1 parent a34d33d
commit d835cc9
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/a11y-toggle.js b/a11y-toggle.js
@@ -46,7 +46,7 @@
   document.addEventListener('click', function (event) {
     var toggle = event.target;
     var target = targetsMap[toggle.getAttribute(namespace)];
-    var isExpanded = JSON.parse(toggle.getAttribute('aria-expanded'));
+    var isExpanded = toggle.getAttribute('aria-expanded') === 'true';
 
     if (target) {
       toggle.setAttribute('aria-expanded', !isExpanded);

diff --git a/a11y-toggle.min.js b/a11y-toggle.min.js
diff --git a/example/main.js b/example/main.js
@@ -46,7 +46,7 @@
   document.addEventListener('click', function (event) {
     var toggle = event.target;
     var target = targetsMap[toggle.getAttribute(namespace)];
-    var isExpanded = JSON.parse(toggle.getAttribute('aria-expanded'));
+    var isExpanded = toggle.getAttribute('aria-expanded') === 'true';
 
     if (target) {
       toggle.setAttribute('aria-expanded', !isExpanded);