Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/improvements non compliant rewards 1129 #1133

Merged
merged 2 commits into from
Jan 25, 2023
Merged

Fix/improvements non compliant rewards 1129 #1133

merged 2 commits into from
Jan 25, 2023

Conversation

Torresmorah
Copy link
Collaborator

Minor UI improvements in the non-compliant and Rewards Distribution pages

What does this PR do?

Steps to test

  1. Run the project locally.
  2. Go to the non-compliant section.
  3. Check that for resolutions greater than 1280 px wide the elements are displayed in two or more columns.
  4. Go to the rewards distribution page.
  5. Check the responsive design.

Screenshots

non-compliant BPs

Desktop design

imagen
imagen

Mobile design

imagen

Rewards Distribution

Desktop design

imagen
imagen

Mobile design

imagen

@Torresmorah Torresmorah self-assigned this Jan 25, 2023
xavier506
xavier506 approved these changes Jan 25, 2023
View reviewed changes
Copy link
Collaborator

@xavier506 xavier506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xavier506 xavier506 merged commit 1ffa545 into dev Jan 25, 2023
@xavier506 xavier506 deleted the fix/improvements-non-compliant-rewards-1129 branch January 25, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xavier506 xavier506 xavier506 approved these changes

@maemultichain maemultichain Awaiting requested review from maemultichain

@Edwinjrc Edwinjrc Awaiting requested review from Edwinjrc

Assignees

@Torresmorah Torresmorah

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Minor UI improvements in the non-compliant BPs and Reward Distribution section.
2 participants
@Torresmorah @xavier506