As Requested #93
Open
As Requested #93
+177
−114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… adding and removing of nodes work
…, also cleaning up logging messages
Unable to initialize replicaset with mongo driver 1.8.0
|
I've tested this cookbook for replica sets many times and its working very well. |
|
Second that, the changes made makes the cookbook actually work as promised when working with replica sets. |
|
Mad Props on the worst PR title and description ever! I'm not a big fan of using parens everywhere, and a few other nits. But it sounds like this is worth merging. |
Open
|
Can we get a rebase and a merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
here you go.