Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error thrown on when "funding sources" selected from dropdown in funding sources index #86

Closed
markgdawson opened this issue Jul 31, 2019 · 2 comments · Fixed by markgdawson/cogs3#5
Labels
urgent needs fixing before next PR to live

Comments

@markgdawson
Copy link
Collaborator

Error thrown by endpoint:
http://localhost:8000/en-gb/funding/list/fundingsources/

Seems like the route might be missing

@markgdawson
Copy link
Collaborator Author

Same error thrown by:
http://localhost:8000/en-gb/funding/list/publications/

@edbennett edbennett added the urgent needs fixing before next PR to live label Aug 1, 2019
@edbennett
Copy link
Owner

This is a model problem, not a route problem.

FundingSource and Publication are two subclasses of the Attribution model. The views mentioned work by inheriting AttributionListView and setting which model to operate on. Within the get_queryset method, the queryset is filtered using fundingsource__in - i.e. checking the value of the fundingsource attribute of the model. This is only defined on the Attribution model, not on the FundingSource and Publication models that inherit from it, hence the error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
urgent needs fixing before next PR to live
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants