-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds downfall env to tests and hub #176
Conversation
Some of my examples had the default scene set to onnx inference for easier running, but it doesn't allow tests to work. I've set training scenes to default in edbeeching/godot_rl_agents_examples#28. It will require updating the datasets on huggingface, e.g. https://huggingface.co/datasets/edbeeching/godot_rl_3DCarParking |
This reverts commit 03c9c24.
Thanks @Ivan-267 , the tests seem to be working now. Ok to merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what's wrong with the windows tests. I'll rerun and check the results later.
I've downloaded the envs from the hub manually Seems to work fine on the second and third try. Will have to test more. Another thing to check after finding out the cause is why the linux tests are running fine. |
It works from the editor, but when running the prebuilt exe of e.g. BallChase, I get an error that the data folder including net assemblies is missing. It does work after that on my PC, but might cause the issue on the test server. Edit: I tried building and got the error. It's related to the csproj file. E.g. in BallChase: <Project Sdk="Godot.NET.Sdk/4.2.1">
<PropertyGroup>
<TargetFramework>net6.0</TargetFramework>
<EnableDynamicLoading>true</EnableDynamicLoading>
</PropertyGroup>
<ItemGroup>
<PackageReference Include="Microsoft.ML.OnnxRuntime" Version="1.14.1" />
<PackageReference Include="Microsoft.ML.OnnxRuntime.DirectML" Version="1.14.1" />
<PackageReference Include="Microsoft.ML.OnnxRuntime.Gpu" Version="1.14.1" />
<PackageReference Include="System.Numerics.Tensors" Version="0.1.0" />
</ItemGroup>
</Project> Having three onnxruntimes causes conflicts. It should only be the first one. We might have to update the envs with new plugins or at least .csproj files. I've I'll update all envs that timed out in tests to the latest plugin and .csproj/.sln files. |
@Ivan-267 that fixed everything, thanks. Merging. |
No description provided.