This repository has been archived by the owner on Jun 1, 2022. It is now read-only.
typescript: parametrize World and System over Entity #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, thank you! I'll update |
simonihmig
added a commit
to simonihmig/ecsy
that referenced
this pull request
Oct 7, 2020
In line with ecsyjs#248, this parameterizes the use of `World` in `System`, allowing you to have a subclass of `World` (a.o. `ecsy-three`) and `System.world` correctly reflecting that.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This is a super simple PR introducing:
<Entity>parametrization in the declaration ofWorld<Entity>parametrization is the declaration of the classSystem.Why?
When creating a custom entity, all typings are lost (in favor of the base
Entityclass) increateEntityand inside inherited systems. It can make the framework a bit unpleasant to use, either because you need to cast first tounknown, or because you need to create an intermediate system class.