This repository has been archived by the owner on Jun 1, 2022. It is now read-only.
Return more readonly components #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sheepsteak
commented
Aug 2, 2020
| if (!component) { | ||
| return; | ||
| } | ||
|
|
There was a problem hiding this comment.
No point going through queries if the component does not exist.
sheepsteak
commented
Aug 2, 2020
| @@ -52,7 +52,7 @@ export class Entity { | |||
| */ | |||
| getMutableComponent<C extends Component<any>>( | |||
| Component: ComponentConstructor<C> | |||
| ): C; | |||
| ): C | undefined; | |||
There was a problem hiding this comment.
Do you think this will be annoying? Should these functions throw an error (in development mode?) instead if the component does not exist?
There was a problem hiding this comment.
I think it's valuable to return undefined so you could check in your code if it exist or not instead of catching an error
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some small changes to help with TypeScript development
undefinedandReadonlycomponentsgetRemovedComponentas wellgetComponentcould already return a readonly removed component so this should too