New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ECO-1556] Enforce valid emojis in a Move contract #5

Merged

alnoki merged 22 commits into main from ECO-1556

Apr 16, 2024

Collaborator

xbtmatt commented Apr 12, 2024 •

edited

Loading

Description

Parse all valid utf-8 representations of unique individual emojis that can fit within 10 bytes, hence can function as a symbol for an Aptos coin.
Revisit the decision to include unquailfied and/or minimally qualified emojis. Fully qualified might be the way to go so we don't run into issues with displays not showing correct things. (Specifically with the variant selector [ECO-1569] Refactor market registration #16: \uFE0F)
Only include fully-qualified, to avoid potential rendering issues on platforms that do not render the optional non-fully-qualified format
Verify package publishability

Checklist

~~Did you update relevant documentation?~~
Did you add tests to cover new code or a fixed issue?
~~Did you update the changelog?~~
Did you check off all checkboxes from the linked Linear task?

xbtmatt requested a review from alnoki

April 12, 2024 07:20

xbtmatt self-assigned this

alnoki reviewed

View reviewed changes

src/move/Move.toml Outdated Show resolved Hide resolved

alnoki reviewed

View reviewed changes

cfg/pre-commit-config.yaml Outdated Show resolved Hide resolved

alnoki reviewed

View reviewed changes

src/move/sources/main.move Outdated Show resolved Hide resolved

alnoki reviewed

View reviewed changes

src/python/move_emojis/code_point.py Outdated Show resolved Hide resolved

alnoki reviewed

View reviewed changes

src/python/move_emojis/data/emoji-test.txt Outdated Show resolved Hide resolved

alnoki reviewed

View reviewed changes

src/python/move_emojis/data/emoji-zwj-sequences.txt Outdated Show resolved Hide resolved

alnoki reviewed

View reviewed changes

src/python/move_emojis/emojis_to_const.py Outdated Show resolved Hide resolved

alnoki reviewed

View reviewed changes

src/python/move_emojis/emojis_to_const.py Outdated Show resolved Hide resolved

alnoki reviewed

View reviewed changes

src/python/move_emojis/emojis_to_const.py Outdated Show resolved Hide resolved

alnoki reviewed

View reviewed changes

src/python/move_emojis/emojis_to_const.py Outdated Show resolved Hide resolved

alnoki reviewed

View reviewed changes

src/python/move_emojis/emojis_to_const.py Outdated Show resolved Hide resolved

alnoki reviewed

View reviewed changes

src/python/move_emojis/README.md Outdated Show resolved Hide resolved

alnoki reviewed

View reviewed changes

src/python/move_emojis/README.md Outdated Show resolved Hide resolved

xbtmatt added 9 commits

April 13, 2024 21:07


          Add emoji parser and Move const string generation tool with a sample …

cccd6d6

…Move contract


          Change code_point function names to be clearer

639d85c

Add doc strings to some of the functions


          Fetch emoji data with a get request, alphabetize cspell, update comme…

a817ee2

…nts, clean up code a bit, update flake8 to match black line length

Alphabetize Move constant variable names, add known first party to isort config


          Fix isort to work correctly when run locally

72ae337


          Fix isort to work in CI by passing config args directly

0130b86


          Remove verbose from isort

7d2e02a


          Remove unnecessary comment, remove debug prints in poetry subdir bash…

2691c8b

… script


          Update README.md word

b9363d4

Add typings to everything in Python


          Fix typings by changing from stubs to regular file

874f598

xbtmatt force-pushed the ECO-1556 branch from f9f08b6 to 874f598 Compare

April 14, 2024 04:07

alnoki reviewed

View reviewed changes

src/move/sources/main.move Outdated Show resolved Hide resolved

alnoki mentioned this pull request

[ECO-1562] Begin preliminary struct architecture #6

Merged

4 tasks

alnoki reviewed

View reviewed changes

src/python/hooks/file_name_conventions.py Outdated Show resolved Hide resolved

alnoki and others added 2 commits

April 14, 2024 15:58


          [ECO-1562] Begin preliminary struct architecture (#6)

c7b8890


          Fix behavior of getting the largest viable qualification

d5cb06a

xbtmatt added 2 commits

April 14, 2024 18:03


          Sort, split up, and de-caseify cspell words

f4c16ed


          Re-organize file structure

9edd6d8

Re-organize file structure

xbtmatt force-pushed the ECO-1556 branch from adf6183 to 9edd6d8 Compare

April 15, 2024 04:34

xbtmatt added 5 commits

April 15, 2024 15:48


          Only use fully qualified emojis, change vector to raw bytes vector of…

241f89b

… vectors, and inline the function from hex_codes.move


          Fix doc string

bda124c


          Add latexindent to cspell in pre-commit

6a0cb17


          Change str | bytes to Union[str, bytes] to satisfy mypy

42dd581


          Add zeroed vector and a simple emoji support unit test to contract

4e2e4b2

xbtmatt requested a review from alnoki

April 16, 2024 00:08

xbtmatt marked this pull request as ready for review

April 16, 2024 00:09

xbtmatt added 4 commits

April 15, 2024 17:16


          Add unit test to verify all emoji hex codes are less than 10 bytes

9f122be


          Move string builder code generation code out to a function

e755d88


          Add a few comments and remove some redundant code

2b65499


          Fix zeroed string vec type generation

360361b

alnoki approved these changes

View reviewed changes

alnoki merged commit 41b486f into main

1 check passed

alnoki deleted the ECO-1556 branch

April 16, 2024 00:50

xbtmatt commented

View reviewed changes

src/python/move_emojis/scripts/generate_code.py Show resolved Hide resolved

xbtmatt pushed a commit that referenced this pull request


          # This is a combination of 5 commits.

dfeb601

# This is the 1st commit message:

First attempt at slugs and data, only market registration sample data right now though

# The commit message #2 will be skipped:

# Try empty fetch

# The commit message #3 will be skipped:

# Try empty fetch

# The commit message #4 will be skipped:

# Try empty fetch

# The commit message #5 will be skipped:

# Try empty fetch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet