Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ECO-1571] Add abstracted unit testing #37

Merged
merged 20 commits into from
May 3, 2024
Merged

[ECO-1571] Add abstracted unit testing #37

merged 20 commits into from
May 3, 2024

Conversation

alnoki
Copy link
Member

@alnoki alnoki commented May 2, 2024

Description

Restructuring

  1. Modify package dependencies, market registration to enable simplified market
    registration during testing.
  2. Simplify Python script used for generating coin factory bytecode.
  3. Clarify supplemental chat emojis.
  4. Use immutable package definitions for coin factories.

Testing framework

  1. Add consolidated testing module that is separate from main code.
  2. Add auxiliary testing module for acquires statement isolation.
  3. Migrate all tests to main test module.
  4. Add assorted test only functions.

Housekeeping

  1. Modify PR template so it is easier to clear out content at bottom via
    multi-line delete in Vim.
  2. Incorporate integrator fee paid in MarketRegistration event.
  3. Change chat message length to a u64 to eliminate casting operation gas.

Testing

cd src/move/emojicoin_dot_fun
git ls-files | entr -c aptos move test --dev

Checklist

  • Did you update relevant documentation?
  • Did you add tests to cover new code or a fixed issue?
  • Did you update the changelog?
  • Did you check off all checkboxes from the linked Linear task?

Copy link

vercel bot commented May 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
emojicoin-dot-fun ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 3, 2024 4:57pm

@alnoki alnoki marked this pull request as ready for review May 3, 2024 04:32
Copy link
Collaborator

@xbtmatt xbtmatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked it over, it's much cleaner this way, and thanks for cleaning up some of my stuff...

I also ran the tests and the code generation myself, LGTM!

@alnoki alnoki merged commit ef812e5 into main May 3, 2024
6 checks passed
@alnoki alnoki deleted the ECO-1571 branch May 3, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants