Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ECO-2311] Increase the max wait time for the frontend container being healthy and for the playwright setup timeout #306

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

xbtmatt
Copy link
Collaborator

@xbtmatt xbtmatt commented Oct 17, 2024

Description

Change it in both places, in playwright config setTimeout and in the docker-test-harness.ts file as well.

  • Change it in the Playwright set timeout function
  • Change it in the SDK docker-test-harness.ts function

Testing

Tests will run in CI.

Checklist

  • Did you update relevant documentation?
  • Did you add tests to cover new code or a fixed issue?
  • Did you update the changelog?
  • Did you check all checkboxes from the linked Linear task?

@xbtmatt xbtmatt requested a review from CRBl69 October 17, 2024 19:12
Copy link

vercel bot commented Oct 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
emojicoin-dot-fun ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 17, 2024 10:37pm
emojicoin-dot-fun-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 17, 2024 10:37pm

@CRBl69 CRBl69 merged commit 6f51751 into main Oct 18, 2024
10 checks passed
@CRBl69 CRBl69 deleted the ECO-2311 branch October 18, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants