Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ECO-2195] Add market discovery rain #304

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

[ECO-2195] Add market discovery rain #304

wants to merge 10 commits into from

Conversation

CRBl69
Copy link
Collaborator

@CRBl69 CRBl69 commented Oct 17, 2024

Description

This PR makes it rain.

The launch page now rains with random unregistered market names.

Clicking on one will pre-fill the input.

Testing

See vecrel.

Copy link

vercel bot commented Oct 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
emojicoin-dot-fun ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2024 1:16pm
emojicoin-dot-fun-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2024 1:16pm

@CRBl69 CRBl69 added urgency-low Can check after high/medium urgency size-medium A medium sized PR. This can be reviewed and merged in a moderate amount of time. labels Oct 28, 2024
Copy link
Collaborator

@xbtmatt xbtmatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Visiting the launch page doesn't seem to show anything for me- is it working? I am just going to the launch page. I waited for a few minutes and still don't see anything

@@ -364,6 +365,7 @@ export type DatabaseJsonType = {
close_price_q64: Uint64String;
}
>;
[DatabaseRpc.RandomNames]: { emojis: string };
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a more specific format to expect? It looks like it might be in the form of hex with an x prepended? It'd be nice to have it here just so it's clear what to expect when calling this function

You can do something like x${string}

@CRBl69
Copy link
Collaborator Author

CRBl69 commented Oct 31, 2024

@xbtmatt nothing is showing up because the backend is not up to date and does not have the random_symbols function present.

@CRBl69 CRBl69 marked this pull request as draft November 5, 2024 18:14
@@ -365,6 +366,7 @@ export type DatabaseJsonType = {
ProcessedFields &
UserLPCoinBalance & { daily_volume: Uint128String }
>;
[DatabaseRpc.RandomSymbols]: { emojis: string };
Copy link
Collaborator

@xbtmatt xbtmatt Dec 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[DatabaseRpc.RandomSymbols]: { emojis: string };
[DatabaseRpc.RandomSymbols]: { emojis: `\x${string}` };

Let's update this if this is the case- not sure if it actually is though

Copy link
Collaborator

@xbtmatt xbtmatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the changes I mentioned- ideally we don't use useWindowSize because it's a fairly heavy hook afaik, but mostly you can do everything with pure css with vw and vh

Also, this is a fairly obtrusive design, I think we should add a switch toggle to enable it and have it disabled by default or it might end up just confusing/irritating people, unfortunately...

Copy link
Collaborator

@xbtmatt xbtmatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to add the config for the switch to have this disabled by default but let users add it in when viewing the page

Copy link
Collaborator

@xbtmatt xbtmatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Things to note discussed on call with Kirsten:

  1. Make the "Select emoji" section more opaque than the rest, and have a higher z-index than the emojis fallling
  2. Rotate the emojis like the other interaction?

More, but just wanted to write down really quick

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size-medium A medium sized PR. This can be reviewed and merged in a moderate amount of time. urgency-low Can check after high/medium urgency
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants