Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ECO-2188] Revise indexer NAT gateway(s), rules, autoscaling #264

Merged
merged 66 commits into from
Sep 30, 2024
Merged

Conversation

alnoki
Copy link
Member

@alnoki alnoki commented Sep 26, 2024

Description

cfn-lint

The following cfn-lint issues have been addressed, enabling template rules:

  1. [Bug] Impossible, rules-unaware condition errors aws-cloudformation/cfn-lint#3630
  2. [Bug] Rules support Condition, which is not a rule-specific intrinsic function aws-cloudformation/cfn-lint#3710

Hence:

  1. Bump cfn-lint version in pre-commit config.
  2. Convert cascaded MaybeDeploy* conditions to Deploy* rules with asserts.

NAT gateways

  1. Update NAT gateway architecture to have redundant NAT gateways per AWS best
    practices.
  2. Create new private route tables and subnet associations for one NAT gateway
    per subnet.
  3. Abstract associated resource creation using Fn::ForEach operator.

Autoscaling

  1. Abstract autoscaling targets and policies for broker and PostgREST.
  2. Use target autoscaling for scaling out, and custom step scaling for scaling
    in, effectively silencing an erroneous alarm for low CPU usage on an idle
    single container.

Miscellaneous

  1. Update README line breaking and stack name setting commands.
  2. Update README to reflect new simplified Deploy* parameters.
  3. Document autoscaling and NAT gateway architectures.
  4. Remove extraneous !Ref and/or !Sub commands where not needed.
  5. Bump processor and broker binaries per recent code changes.
  6. Remove general cache against /* due to wildcard issues.

Testing

REST and WS public endpoints were verified before the binaries were updated in 74c71ee, which required a redeployment of the stack due to breaking migrations reversions. Once backfilled, the endpoints can be tested again.

Checklist

  • Did you update relevant documentation?
  • Did you check all checkboxes from the linked Linear task?

xbtmatt

This comment was marked as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants