Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ECO-2105] Add ws server #37

Merged
merged 3 commits into from
Aug 21, 2024
Merged

[ECO-2105] Add ws server #37

merged 3 commits into from
Aug 21, 2024

Conversation

CRBl69
Copy link
Collaborator

@CRBl69 CRBl69 commented Aug 21, 2024

This PR adds a Websocket server to the processor so that it can send events to brokers.

@CRBl69 CRBl69 requested review from alnoki and xbtmatt August 21, 2024 10:41
Copy link

@xbtmatt xbtmatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for knocking this out, looks good to me so far

Just noting here the two things we discussed on call:

  1. Emit the events as the coupled data, in the processor they're all vectors suffixed with _db, we send them into insert_to_db(...):
  &register_events_db,
  &swap_events_db,
  &chat_events_db,
  &liquidity_events_db,
  &periodic_state_events_db,
  &global_state_events_db,
  1. Also emit the market_latest_state_events, which will be the equivalent of the old latest_state_event emission we did for bump order, for example
  2. Eventually we'd like to decouple the websocket server status from the processor itself, that way if it crashes/errors it can just restart and not stop the processor as well. That can be for another PR, will note it in a task

@xbtmatt xbtmatt merged commit 1000b77 into emojicoin-dot-fun Aug 21, 2024
1 of 4 checks passed
@xbtmatt xbtmatt deleted the add-ws-server branch August 21, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants