[ECO-731] sanitize address before insertion into the db #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliottdehn
suggested changes
Oct 18, 2023
| @@ -782,7 +792,7 @@ impl ProcessorTrait for EconiaTransactionProcessor { | |||
| .expect("Failed to parse MarketAccounts"); | |||
| let map_field = data.get("map").expect("No map field"); | |||
| market_account_handles.push(MarketAccountHandle { | |||
| user: resource.address.clone(), | |||
| user: strip_hex_number(resource.address.clone())?, | |||
| handle: opt_value_to_string(map_field.get("handle"))?, | |||
There was a problem hiding this comment.
fn event_data_to_place_market_order_event has integrator which is an address, as does fn event_data_to_place_limit_order_event and fn event_data_to_place_swap_order_event. Now that I look at it, event_data_to_place_swap_order_event also has signing_account which is another address.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
[ECO-775] Sanitize Econia address, check decode
alnoki
approved these changes
Oct 20, 2023
elliottdehn
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.