-
-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sabelhaus & Song (2010) age profiles of income volatility #921
Conversation
…into Calibration/Sabelhaus
This PR is now ready. I'd like to request review @sbenthall @llorracc . I am still looking for feedback on the location and format of these tools. Yet, I am very happy with the results. @llorracc I added smoothing using a polynomial by default as you requested, but kept the option to get the original results (see the example file). I am particularly satisfied with the tests: they check the outputs against the coefficients from the original paper. Also, they check that smoothed versions are not more than 10% off from the original results. I also added a README in the folder crediting John Sabelhaus. |
This PR adds tools to produce age-profiles of income volatilities from Sabelhaus & Song (2010). It uses the original estimates from the paper, which were generously shared by John Sabelhaus.
The code is pretty much ready but I'm looking for feedback on:
ConsIndShockModel.py
? Would this be considered a dataset and thus be better placed atHARK/datasets
(re: @sbenthall 's comment ininit_lifecycle
should be replaced with a real life cycle calibration #592)?I also need to better document the time units (#878).