namespace for control variables #855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR includes all the commits from i836, which should be merged FIRST. |
|
I just saw the merge conflicts and have pushed the resolution. Requesting review and merge from @mnwhite After this PR, I will start working on cutting the 0.10.8 release. |
|
Before cutting the release, I will fix the DemARKS! |
|
Reminder: @mnwhite request for review |
|
This is exactly analogous to prior PR, and local tests pass. This should be good for merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This puts each 'control' variable into a namespace,
controls, similar toshocks.It does not adjust the storage to use '_now' or '_prev' dictionaries for the controls.
We can discuss this choice in the meeting -- fore example, whether we prefer to put all the 'model variables' including shocks and controls into 'now' and 'prev' dicts.
This is passing tests locally.