Issue 404 - refactoring simulation.py #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MridulS
reviewed
Oct 21, 2019
HARK/simulation.py
Outdated
| @@ -33,19 +33,13 @@ def drawMeanOneLognormal(N, sigma=1.0, seed=0): | |||
| # Set up the RNG | |||
| RNG = np.random.RandomState(seed) | |||
There was a problem hiding this comment.
This isn't needed in this function as the seed is passed on to drawLognormal.
MridulS
reviewed
Oct 21, 2019
HARK/tests/test_simulation.py
Outdated
|
|
||
| class SimulationTests(unittest.TestCase): | ||
| ''' | ||
| Tests for .... |
There was a problem hiding this comment.
sampling distribution with default seed?
PS: looks like import sys isn't used
|
I corrected based on @MridulS 's feedback. Based on today's meeting, my understanding now is that So I won't do any more refactorings in this PR. I submit this PR to be reviewed and pulled. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for refactoring of simulation.py as per #404
Currently it:
I would like to go farther and refactor more of the distribution sampling code to be more concise.
But I'm making this PR mainly to test project workflow.