-
-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT: Bump up min python version to 3.10 to align with SPEC 0 #1415
Conversation
The test failures are coming from the changes in interpolation.py |
So we still can't bump up to 3.12? Do we know if these are fixable errors or does interpolation.py still not allow us to move up? |
can you take a look at this when you have time @Mv77? |
I'd be happy to. But to make sure I have the right version of everything, is there any yaml file with the environment that I should use while checking the tests? |
|
I'll run that in a clean python 3.12 env and report back. |
Can confirm all econforge tests fail locally. Debugging. |
Here's a PR to @MridulS 's branch that fixes the issue. Pablo changed the name of a parameter in one of the main functions. All tests pass locally except for an unrelated one, @sbenthall
|
It looks like there are now unrelated errors having to do with assertions? It is strange that I did not get those locally. |
#1420 fixes a typo that is making the 3.12 versions fail. What I can't figure out is why 3.11 is failing. There are some failures related to properties of numpy arrays that I can not reproduce locally on a fresh 3.11 env. |
Model test bugfix
mac numpy doesn't like comparing arrays with floats
Do they fail locally for you @alanlujan91 ? |
no, but they are failing on the mac tests and I have a windows, so I am trying to "guess" what a mac would like, we'll see if it passes! |
MAC: It just doesn't work^{TM} (works fine in my local ubuntu too) |
@Mv77 I think i'm getting close, only 1 failing test on mac now! |
UGHHH everything is passing except for coverage I agree with @MridulS that we should remove it |
We should probably look into loosely following https://scientific-python.org/specs/spec-0000
Numba supports python 3.12 too, so hopefully we should be able to bump up things all around.
The coverage action is broken, it doesn't really upload anything (returns a 404 error), we should probably remove it unless someone is actively monitoring it?