Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Methods to Compute Jacobian Matrices #1185

Merged
merged 8 commits into from
Dec 2, 2022

Conversation

wdu9
Copy link
Collaborator

@wdu9 wdu9 commented Nov 4, 2022

Please ensure your pull request adheres to the following guidelines:

  • Tests for new functionality/models or Tests to reproduce the bug-fix in code.
  • Updated documentation of features that add new functionality.
  • Update CHANGELOG.md with major/minor changes.

@codecov-commenter
Copy link

codecov-commenter commented Nov 17, 2022

Codecov Report

Base: 72.81% // Head: 73.56% // Increases project coverage by +0.74% 🎉

Coverage data is based on head (5d37ccb) compared to base (20645e2).
Patch coverage: 99.27% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1185      +/-   ##
==========================================
+ Coverage   72.81%   73.56%   +0.74%     
==========================================
  Files          72       72              
  Lines       11803    11941     +138     
==========================================
+ Hits         8594     8784     +190     
+ Misses       3209     3157      -52     
Impacted Files Coverage Δ
HARK/ConsumptionSaving/ConsIndShockModel.py 86.50% <99.23%> (+7.03%) ⬆️
...nsumptionSaving/tests/test_IndShockConsumerType.py 79.01% <100.00%> (+0.46%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@wdu9
Copy link
Collaborator Author

wdu9 commented Nov 17, 2022

@Mv77 @AMonninger A Could you guys take a look at this when you get the chance?

@AMonninger
Copy link
Collaborator

Looks good to me!
(I like the comments in the code, they make it easy to follow)

@wdu9
Copy link
Collaborator Author

wdu9 commented Nov 25, 2022

Looks good to me! (I like the comments in the code, they make it easy to follow)

Just updated the documentation to be clearer in the calc_jacobian function. In particular, the fake news algorithm is much clearer now.

@AMonninger
Copy link
Collaborator

Looks good to me!
Minor Comments:

  • In ConsIndShockModel.py line 2676: "Jacobian Matrix ia TxT square Matrix" --> "ia" instead of "is a"
  • In ConsIndShockModel.py line 2711: Remove commented line

@alanlujan91 alanlujan91 self-requested a review December 2, 2022 19:07
@alanlujan91 alanlujan91 merged commit cfaaf25 into econ-ark:master Dec 2, 2022
@sbenthall sbenthall added this to the 0.13.0 milestone Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants