Linear aXtraGrid #1172
Merged
Linear aXtraGrid #1172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 73.58% // Head: 73.57% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1172 +/- ##
==========================================
- Coverage 73.58% 73.57% -0.01%
==========================================
Files 72 72
Lines 11465 11462 -3
==========================================
- Hits 8436 8433 -3
Misses 3029 3029
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
see #1171 To do: unit test |
|
Is this ready to merge? |
|
@llorracc this is ready to review, I have moved |
alanlujan91
added
Status: Review Needed
TSC: Review Needed
to do : make more general use with abstract grids |
sbenthall
reviewed
Sep 21, 2022
| "aXtraNestFac": -1, | ||
| } | ||
|
|
||
| params = SimpleNamespace(**params) |
There was a problem hiding this comment.
cool choice. hadn't heard of SimpleNamespace before
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates linearly spaced asset grid for models that inherit from
IndShockConsumerTypewhenaXtraNestFac == -1.