Fix transformations between normal and lognormal parameters #1076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix `calc_normal_style_pars_from_lognormal_pars` where sqrt was not needed; other changes to avoid repeated calculations
add test to ensure transformation methods work as expected
alanlujan91
commented
Nov 2, 2021
Comment on lines
-913
to
+915
| varNormal = math.sqrt(math.log(1 + varLognormal / avg_lognormal ** 2)) | ||
| varNormal = math.log(1 + varLognormal / avg_lognormal ** 2) |
There was a problem hiding this comment.
The sqrt is not needed since this is the variance.
Codecov Report
@@ Coverage Diff @@
## master #1076 +/- ##
==========================================
+ Coverage 73.60% 73.68% +0.07%
==========================================
Files 68 68
Lines 10477 10487 +10
==========================================
+ Hits 7712 7727 +15
+ Misses 2765 2760 -5
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a math error in
calc_normal_style_pars_from_lognormal_pars.