Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes bugs with authentication, header, and performance. #50

Merged
merged 7 commits into from
May 25, 2016

Conversation

sophiabersani
Copy link
Contributor

@sophiabersani sophiabersani commented May 24, 2016

Stories:

https://www.pivotaltracker.com/story/show/120195889
https://www.pivotaltracker.com/story/show/120106289
https://www.pivotaltracker.com/story/show/120192313

  • Fixes issue with missing Header titles.
  • Fixes an issue with authentication.
  • Updates Realm package version to fix a memory leak.
  • Fixes some slowdowns caused by the 3rd party Drawer being wired up with setState() methods.
    • Note: While the fix takes care of some of the overdone re-rendering caused by this component, the app is still unacceptably slow when using this menu.
    • These slowdowns might be being caused by Realm instead of the component, as they seem to happen when a View needs to load data from it. This is happening with both debuggers ON and OFF, updating the package helped with some of it, but it's still far from smooth.

@sophiabersani sophiabersani changed the title Bug fixes and some performance tweaks Fixes bugs with authentication, header, and performance. May 24, 2016
@dan-nyanko dan-nyanko merged commit 48ff0a6 into master May 25, 2016
@dan-nyanko dan-nyanko deleted the bug-fixes-and-performance branch May 25, 2016 12:21
@appden
Copy link

appden commented May 26, 2016

@gbersani I work on the Realm React Native binding. Would you mind telling me how I can reproduce these slowdowns in this app so I can investigate further? We definitely recognize that running in Chrome debug mode slows things down given how it has to work (discussed in realm/realm-js#390), but it shouldn't be introducing any slowdowns into your app when not debugging. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants