Replaces magic numbers with compile-time variables

[mcakircali]

example: seconds in a day would be eckit::Time::secondsInDay instead of 86400

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 64.06%. Comparing base (ba59e08) to head (9425927).
Report is 6 commits behind head on develop.

Files with missing lines	Patch %	Lines
src/eckit/log/RotationTarget.cc	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop     #159      +/-   ##
===========================================
- Coverage    64.06%   64.06%   -0.01%     
===========================================
  Files         1079     1079              
  Lines        55673    55679       +6     
  Branches      4116     4118       +2     
===========================================
+ Hits         35665    35668       +3     
- Misses       20008    20011       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[simondsmart]

I'm not sure that the type Second is right here. IIRC that is a double - and the count of seconds in * is always integral - and is likely to be used in many integral expressions.

[mcakircali]

I used Second here because DateTime and Time use Second (aka double)

e.g., age calculation cases are Second, while STL uses count time_t (aka long)

so, Second seemed more sensible to me, and no strong opinions.

happy to change if you suggest another type.

[danovaro]

DateTime and Time use floating points to represent sub-second values.
time_t usually expresses the number of seconds since epoch.
For these constants (positive numbers expressing the relationship between time units, thus a-dimensional), I would prefer an integer value such as an unsigned long

[mcakircali]

makes sense. there's useconds_t (aka unsigned int), not unsigned long ..

any rejection to std::uint64_t or to template it secondsInMinute<double/uint64_t>?

[github-actions]

Private downstream CI failed.
Workflow name: private-downstream-ci
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/13069294755.

[github-actions]

Private downstream CI failed.
Workflow name: private-downstream-ci-hpc
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/13069574140.

[github-actions]

Private downstream CI failed.
Workflow name: private-downstream-ci-hpc
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/13070893697.

[github-actions]

Private downstream CI failed.
Workflow name: private-downstream-ci-hpc
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/13072520220.

[github-actions]

Private downstream CI failed.
Workflow name: private-downstream-ci
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/13072936241.

[github-actions]

Private downstream CI failed.
Workflow name: private-downstream-ci
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/13075144704.

[github-actions]

Private downstream CI failed.
Workflow name: private-downstream-ci-hpc
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/13075242941.

[github-actions]

Private downstream CI failed.
Workflow name: private-downstream-ci
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/13075585738.

[github-actions]

Private downstream CI failed.
Workflow name: private-downstream-ci-hpc
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/13075679612.