buffer zero alloc #146
buffer zero alloc #146
Conversation
fix test and add new test
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #146 +/- ##
===========================================
+ Coverage 64.08% 64.09% +0.01%
===========================================
Files 1083 1083
Lines 55759 55775 +16
Branches 4120 4120
===========================================
+ Hits 35735 35751 +16
Misses 20024 20024 ☔ View full report in Codecov by Sentry. |
|
Please could you provide a description to the issue and what this is solving? |
done |
There was a problem hiding this comment.
Looking at Buffer this could be simplified by using std::vector<>char as backing container.
This would remove some code such as allocate/deallocate
Further It would be good to add documentation to the public interface since you already touched this class. Construction from std::string and copy from std::string deserve a short hint in the api doc imo as they treat std::string as a null terminated c-string. i.e. the resulting buffer length is string.size() + 1.
|
|
|
pushed doc after talking to @mcakircali Edit: Also the Buffer dtor should be virtual as this class is subclassed and has protected members. I think making this class final would be better but that chan get the API |
|
Private downstream CI failed. |
|
Private downstream CI failed. |
|
Private downstream CI failed. |
|
Private downstream CI failed. |
|
Private downstream CI failed. |
|
Private downstream CI failed. |
|
Private downstream CI succeeded. |
2 similar comments
|
Private downstream CI succeeded. |
|
Private downstream CI succeeded. |
|
Private downstream CI succeeded. |
5 similar comments
|
Private downstream CI succeeded. |
|
Private downstream CI succeeded. |
|
Private downstream CI succeeded. |
|
Private downstream CI succeeded. |
|
Private downstream CI succeeded. |
|
Private downstream CI succeeded. |
5 similar comments
|
Private downstream CI succeeded. |
|
Private downstream CI succeeded. |
|
Private downstream CI succeeded. |
|
Private downstream CI succeeded. |
|
Private downstream CI succeeded. |
|
Private downstream CI succeeded. |
2 similar comments
|
Private downstream CI succeeded. |
|
Private downstream CI succeeded. |
fixes zero size allocation issue such when
size=0. namely,new char[size]in such state,
buffer.data() != nullptris not expected butbuffer.data() == nullptr