Feature/syslog structured data #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #122 +/- ##
===========================================
+ Coverage 61.98% 62.11% +0.13%
===========================================
Files 900 901 +1
Lines 49799 49850 +51
Branches 3745 3749 +4
===========================================
+ Hits 30866 30966 +100
+ Misses 18933 18884 -49 ☔ View full report in Codecov by Sentry. |
|
Hi @sametd, I'm not aware of why this PR is needed, so I'm not really qualified for a review. It looks good though! :-) |
simondsmart
reviewed
Jun 3, 2024
| @@ -99,6 +99,11 @@ class SysLog { | |||
| return s; | |||
| } | |||
|
|
|||
| /// Optional fields for structured data (RFC 5424 section 6.3) | |||
| void software(const std::string& software) { software_ = software; } | |||
There was a problem hiding this comment.
Where are these being set?
There was a problem hiding this comment.
These are the keywords that belongs to origin part of the syslog structural data described in RFC5424 -> https://datatracker.ietf.org/doc/html/rfc5424#section-7.2
|
Looks uncontroversial. Why is there a failing test? |
simondsmart
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the "origin" component of the syslog structural data as described in RFC5424, specifically in sections 6.2 and 7.2 (RFC5424 Section 7.2). Implementation also ensures that the current functionality remains unaffected if the newly introduced variables are not set. I am tagging @tlmquintino here as he may also want to take a look at this implementation.
Note: This is not a full implementation of structural data of the syslog, only implements the bits that necessary to add logserver-compatible logging. Logserver repo can be found here